Bug fix: message, time, level keyword in KeyValue#1379
Merged
TharmiganK merged 16 commits intoballerina-platform:masterfrom Oct 23, 2025
Better-Boy:log-bug-fix
Merged
Bug fix: message, time, level keyword in KeyValue#1379TharmiganK merged 16 commits intoballerina-platform:masterfrom Better-Boy:log-bug-fix
message, time, level keyword in KeyValue#1379TharmiganK merged 16 commits intoballerina-platform:masterfrom
Better-Boy:log-bug-fix
Conversation
Better-Boy
requested review from
TharmiganK,
daneshk,
lnash94 and
shafreenAnfar
as code owners
Better-Boy
changed the title
message keyword in KeyValuemessage, time, level keyword in KeyValue
Contributor
|
@Better-Boy please update the changelog and spec if applicable |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1379 +/- ##
=========================================
Coverage 81.67% 81.67%
Complexity 81 81
=========================================
Files 8 8
Lines 562 562
Branches 114 114
=========================================
Hits 459 459
Misses 76 76
Partials 27 27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
@TharmiganK Done |
TharmiganK
reviewed
Oct 13, 2025
Co-authored-by: Krishnananthalingam Tharmigan <63336800+TharmiganK@users.noreply.github.com>
TharmiganK
previously approved these changes
Oct 14, 2025
Contributor
TharmiganK
left a comment
TharmiganK
left a comment
There was a problem hiding this comment.
LGTM. @daneshk Please review
Contributor
Author
daneshk
previously approved these changes
Oct 21, 2025
TharmiganK
reviewed
Oct 23, 2025
TharmiganK
reviewed
Oct 23, 2025
Co-authored-by: Krishnananthalingam Tharmigan <63336800+TharmiganK@users.noreply.github.com>
Co-authored-by: Krishnananthalingam Tharmigan <63336800+TharmiganK@users.noreply.github.com>
|
TharmiganK
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Preventing
messagefrom being a key by making it anevertype.Fixes ballerina-platform/ballerina-library#8232
Fixes ballerina-platform/ballerina-library#7728
Checklist
Added testsChecked native-image compatibility