Add ICP agent configurations to the log message when ICP agent running#1393
Merged
anuruddhal merged 13 commits intoballerina-platform:masterfrom Dec 1, 2025
Merged
Conversation
NipunaMadhushan
requested review from
TharmiganK,
daneshk,
lnash94 and
shafreenAnfar
as code owners
NipunaMadhushan
changed the title
TharmiganK
reviewed
Oct 16, 2025
ballerina/Dependencies.toml
Outdated
| [ballerina] | ||
| dependencies-toml-version = "2" | ||
| distribution-version = "2201.12.0" | ||
| distribution-version = "2201.13.0-20251016-073200-0d348172" |
Contributor
There was a problem hiding this comment.
Any reason to bump the lang version? Can't we do it as a patch on top of update 12?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1393 +/- ##
=========================================
Coverage 79.95% 79.95%
Complexity 81 81
=========================================
Files 8 8
Lines 499 499
Branches 93 93
=========================================
Hits 399 399
Misses 73 73
Partials 27 27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TharmiganK
reviewed
Oct 16, 2025
Contributor
|
@NipunaMadhushan Do we have a design/proposal document for this? |
|
anuruddhal
approved these changes
Nov 26, 2025
TharmiganK
reviewed
Nov 26, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This will add ICP runtimeId tag to log messages only if the ICP agent is running.
wso2/integration-control-plane#22
Examples
A sample log message will be displayed as follows.
time=2025-10-16T10:35:22.539+05:30 level=INFO module=nipunal/sample_1 message="Fetching product list" traceId="15f992c0ac10ae018fbb0961f23c6fc3" spanId="66c3d67f6ff5ef62" icp.runtimeId="152819201"Checklist