Skip to content

Remove observabilityEnabled check to include icp.runtimeId #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daneshk merged 2 commits into from
Feb 12, 2026
Merged

Remove observabilityEnabled check to include icp.runtimeId #1446

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1b80f1
Remove observabilityEnabled check to include icp.runtimeId
NipunaMadhushan Feb 11, 2026
51c5b8e
Merge branch 'master' into fix-icp-tag
NipunaMadhushan Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions ballerina/root_logger.bal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,11 +149,9 @@ isolated class RootLogger {
logRecord[k] = v;
}
}
if observe:isObservabilityEnabled() {
string? runtimeId = observe:getTagValue(ICP_RUNTIME_ID_KEY);
if runtimeId is string {
logRecord[ICP_RUNTIME_ID_KEY] = runtimeId;
}
string? runtimeId = observe:getTagValue(ICP_RUNTIME_ID_KEY);
Copy link
Contributor

@TharmiganK TharmiganK Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without observability enabled, do we get this tag value? If so why the tag is exposed in observe API instead of a runtime API?

Copy link
Contributor Author

@NipunaMadhushan NipunaMadhushan Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is that isObservabilityEnabled() check becomes true only if any observability provider is set. Otherwise, it remains false even if we have enabled observability in Ballerina.toml

if runtimeId is string {
logRecord[ICP_RUNTIME_ID_KEY] = runtimeId;
}

foreach [string, Value] [k, v] in self.keyValues.entries() {
Expand Down