Fix client connection issue with certain servers#12
Merged
AzeemMuzammil merged 5 commits intoballerina-platform:mainfrom Jul 15, 2025
Merged
Fix client connection issue with certain servers#12AzeemMuzammil merged 5 commits intoballerina-platform:mainfrom
AzeemMuzammil merged 5 commits intoballerina-platform:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes client connection issues by standardizing request paths and updating dependency versions.
- Replaced hardcoded "/" paths with empty strings in HTTP client calls for
post,get, anddelete. - Bumped the
httppackage to 2.14.2 andmcpto 0.4.3, and addedioandlogmodules inDependencies.toml. - Updated the
mcpversion and native JAR path to the new snapshot inBallerina.toml.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ballerina/streamable_http.bal | Use "" as the request path instead of "/" for HTTP client methods. |
| ballerina/Dependencies.toml | Updated package versions and added io and log modules. |
| ballerina/Ballerina.toml | Bumped mcp version to 0.4.3 and adjusted native JAR path to snapshot. |
Comments suppressed due to low confidence (1)
ballerina/streamable_http.bal:60
- I don't see any new tests covering the behavior when the request path is an empty string. Consider adding unit or integration tests to verify that
post,get, anddeletewith an empty path function correctly against target servers.
http:Response response = check self.httpClient->post("", message, headers = headers);
xlight05
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes: ballerina-platform/ballerina-library#8090
Examples
Checklist