Skip to content

Comments

Fix auth being not passed in service config#33

Merged
AzeemMuzammil merged 5 commits intoballerina-platform:mainfrom
AzeemMuzammil:fix/service-config
Oct 30, 2025
Merged

Fix auth being not passed in service config#33
AzeemMuzammil merged 5 commits intoballerina-platform:mainfrom
AzeemMuzammil:fix/service-config

Conversation

@AzeemMuzammil
Copy link
Contributor

@AzeemMuzammil AzeemMuzammil commented Oct 16, 2025

Purpose

$title.
Fixes: ballerina-platform/ballerina-library#8419

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

Copilot AI review requested due to automatic review settings October 16, 2025 06:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes authentication configuration by properly passing auth settings in service configurations and updating MCP library version to 1.0.2. The changes ensure auth configuration is correctly applied across all clients and servers.

  • Updates MCP library dependency from version 1.0.1 to 1.0.2 across all example projects
  • Fixes auth configuration not being passed in HTTP client and service configurations
  • Updates certificate and private key files with corrected paths and new certificates

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
ballerina/streamable_http.bal Refactors HTTP response handling logic and improves error status code validation
ballerina/dispatcher_service.bal Adds authentication calls to HTTP resource methods
examples/clients/mcp-shopping-client/main.bal Adds comprehensive JWT authentication configuration for HTTP client
examples/servers/mcp-shopping-server/main.bal Updates JWT configuration with corrected certificate path and audience
Various .toml files Updates MCP library version to 1.0.2 and dependency versions
Certificate/key files Replaces old certificates with new ones and corrects file paths

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.49%. Comparing base (05b337b) to head (84c02ea).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
ballerina/streamable_http.bal 45.45% 6 Missing ⚠️
ballerina/dispatcher_service.bal 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #33      +/-   ##
============================================
- Coverage     17.60%   17.49%   -0.11%     
  Complexity        3        3              
============================================
  Files            15       15              
  Lines           642      646       +4     
  Branches        170      171       +1     
============================================
  Hits            113      113              
- Misses          528      532       +4     
  Partials          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@MohamedSabthar MohamedSabthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AzeemMuzammil Let's link the issues. Changes LGTM.

@AzeemMuzammil AzeemMuzammil merged commit 2219c63 into ballerina-platform:main Oct 30, 2025
7 checks passed
@AzeemMuzammil AzeemMuzammil deleted the fix/service-config branch October 30, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MCP] Auth config is not getting passed to the MCP service

2 participants