Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ballerina/Ballerina.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ graalvmCompatible = true
groupId = "io.ballerina.stdlib"
artifactId = "sql-native"
version = "1.18.0"
path = "../native/build/libs/sql-native-1.18.0-SNAPSHOT.jar"
path = "../native/build/libs/sql-native-1.18.0.jar"

[[platform.java21.dependency]]
path = "../test-utils/build/libs/sql-test-utils-1.18.0-SNAPSHOT.jar"
path = "../test-utils/build/libs/sql-test-utils-1.18.0.jar"
scope = "testOnly"

[[platform.java21.dependency]]
Expand Down
2 changes: 1 addition & 1 deletion ballerina/CompilerPlugin.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ id = "sql-compiler-plugin"
class = "io.ballerina.stdlib.sql.compiler.SQLCompilerPlugin"

[[dependency]]
path = "../compiler-plugin/build/libs/sql-compiler-plugin-1.18.0-SNAPSHOT.jar"
path = "../compiler-plugin/build/libs/sql-compiler-plugin-1.18.0.jar"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Same JAR path / gradle.properties mismatch as Ballerina.toml lines 19–22.

Gradle at 1.18.1-SNAPSHOT will produce sql-compiler-plugin-1.18.1-SNAPSHOT.jar, but this path still declares sql-compiler-plugin-1.18.0.jar. The same follow-up path-bump PR that fixes Ballerina.toml should address this entry as well.

🔧 Expected fix
-path = "../compiler-plugin/build/libs/sql-compiler-plugin-1.18.0.jar"
+path = "../compiler-plugin/build/libs/sql-compiler-plugin-1.18.1-SNAPSHOT.jar"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
path = "../compiler-plugin/build/libs/sql-compiler-plugin-1.18.0.jar"
path = "../compiler-plugin/build/libs/sql-compiler-plugin-1.18.1-SNAPSHOT.jar"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@ballerina/CompilerPlugin.toml` at line 6, Update the jar path in
CompilerPlugin.toml so it matches the Gradle artifact version used (change the
path string "path =
\"../compiler-plugin/build/libs/sql-compiler-plugin-1.18.0.jar\"" to the
artifact produced by Gradle, e.g. "sql-compiler-plugin-1.18.1-SNAPSHOT.jar" if
gradle.properties uses 1.18.1-SNAPSHOT); ensure the path value in
CompilerPlugin.toml is consistent with the version declared in gradle.properties
and the related Ballerina.toml entries so all three reference the same jar
filename.

8 changes: 4 additions & 4 deletions ballerina/Dependencies.toml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ dependencies = [
[[package]]
org = "ballerina"
name = "crypto"
version = "2.9.3"
version = "2.9.0"
scope = "testOnly"
dependencies = [
{org = "ballerina", name = "jballerina.java"},
Expand Down Expand Up @@ -79,7 +79,7 @@ modules = [
[[package]]
org = "ballerina"
name = "http"
version = "2.14.9"
version = "2.14.0"
scope = "testOnly"
dependencies = [
{org = "ballerina", name = "auth"},
Expand Down Expand Up @@ -256,7 +256,7 @@ dependencies = [
[[package]]
org = "ballerina"
name = "log"
version = "2.13.0"
version = "2.12.0"
scope = "testOnly"
dependencies = [
{org = "ballerina", name = "io"},
Expand Down Expand Up @@ -294,7 +294,7 @@ dependencies = [
[[package]]
org = "ballerina"
name = "observe"
version = "1.5.1"
version = "1.5.0"
scope = "testOnly"
dependencies = [
{org = "ballerina", name = "jballerina.java"}
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
group=io.ballerina.stdlib
version=1.18.0-SNAPSHOT
version=1.18.1-SNAPSHOT
ballerinaLangVersion=2201.13.0

checkstylePluginVersion=10.12.1
Expand Down