Add connectionClosureTimeout service config annotation#1542
Merged
ayeshLK merged 32 commits intoballerina-platform:mainfrom Apr 8, 2025
Merged
Add connectionClosureTimeout service config annotation#1542ayeshLK merged 32 commits intoballerina-platform:mainfrom
connectionClosureTimeout service config annotation#1542ayeshLK merged 32 commits intoballerina-platform:mainfrom
Conversation
ayeshLK
reviewed
Mar 17, 2025
native/src/main/java/io/ballerina/stdlib/websocket/actions/websocketconnector/Close.java
Outdated
Show resolved
Hide resolved
Bhashinee
reviewed
Mar 24, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1542 +/- ##
============================================
- Coverage 82.37% 82.36% -0.01%
- Complexity 591 595 +4
============================================
Files 48 48
Lines 3063 3090 +27
Branches 404 409 +5
============================================
+ Hits 2523 2545 +22
- Misses 397 400 +3
- Partials 143 145 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@chathushkaayash shall we update the websocket spec as well. |
native/src/main/java/io/ballerina/stdlib/websocket/WebSocketConstants.java
Outdated
Show resolved
Hide resolved
…imeout and add tests
...src/main/java/io/ballerina/stdlib/websocket/plugin/WebSocketUpgradeServiceValidatorTask.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/ballerina/stdlib/websocket/plugin/WebSocketUpgradeServiceValidatorTask.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/ballerina/stdlib/websocket/plugin/WebSocketUpgradeServiceValidatorTask.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/ballerina/stdlib/websocket/plugin/WebSocketUpgradeServiceValidatorTask.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/stdlib/websocket/WebSocketUtil.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/stdlib/websocket/actions/websocketconnector/Close.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/stdlib/websocket/server/WebSocketServerService.java
Show resolved
Hide resolved
…for invalid timeout values
…ield type checking
MohamedSabthar
previously approved these changes
Apr 7, 2025
...src/main/java/io/ballerina/stdlib/websocket/plugin/WebSocketUpgradeServiceValidatorTask.java
Outdated
Show resolved
Hide resolved
|
ThisaruGuruge
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Purpose
Resolves Introduce Service Config Annotation for connectionClosureTimeout
Examples
Checklist