Skip to content

Comments

Add connectionClosureTimeout service config annotation#1542

Merged
ayeshLK merged 32 commits intoballerina-platform:mainfrom
chathushkaayash:connection-closure-timeout
Apr 8, 2025
Merged

Add connectionClosureTimeout service config annotation#1542
ayeshLK merged 32 commits intoballerina-platform:mainfrom
chathushkaayash:connection-closure-timeout

Conversation

@chathushkaayash
Copy link
Contributor

@chathushkaayash chathushkaayash commented Mar 17, 2025

Purpose

$subject

Resolves Introduce Service Config Annotation for connectionClosureTimeout

Examples

@websocket:ServiceConfig {
    connectionClosureTimeout: 10
}
service /ws on new websocket:Listener(9090) {
    resource function get .() returns websocket:Service {
        return new WsService();
    }
}

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

@chathushkaayash chathushkaayash marked this pull request as ready for review March 28, 2025 03:59
@codecov
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 84.84848% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.36%. Comparing base (51e29b3) to head (89e8d2b).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
...a/io/ballerina/stdlib/websocket/WebSocketUtil.java 50.00% 3 Missing and 1 partial ⚠️
...ib/websocket/actions/websocketconnector/Close.java 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1542      +/-   ##
============================================
- Coverage     82.37%   82.36%   -0.01%     
- Complexity      591      595       +4     
============================================
  Files            48       48              
  Lines          3063     3090      +27     
  Branches        404      409       +5     
============================================
+ Hits           2523     2545      +22     
- Misses          397      400       +3     
- Partials        143      145       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ThisaruGuruge
ThisaruGuruge previously approved these changes Mar 28, 2025
Copy link
Member

@ThisaruGuruge ThisaruGuruge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayeshLK
Copy link
Member

ayeshLK commented Mar 31, 2025

@chathushkaayash shall we update the websocket spec as well.

MohamedSabthar
MohamedSabthar previously approved these changes Apr 7, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2025

@ayeshLK ayeshLK merged commit f5f23fe into ballerina-platform:main Apr 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce Service Config Annotation for connectionClosureTimeout in Websocket module

6 participants