Skip to content

Comments

Rename @websocket:DispatcherMapping annotation to a more generic name for future extensibility#1566

Merged
MohamedSabthar merged 8 commits intoballerina-platform:mainfrom
chathushkaayash:feat/custom-remote-method-annotation
Apr 30, 2025
Merged

Rename @websocket:DispatcherMapping annotation to a more generic name for future extensibility#1566
MohamedSabthar merged 8 commits intoballerina-platform:mainfrom
chathushkaayash:feat/custom-remote-method-annotation

Conversation

@chathushkaayash
Copy link
Contributor

@chathushkaayash chathushkaayash commented Apr 27, 2025

Purpose

Resolves ballerina-platform/ballerina-library#7839

Examples

@websocket:DispatcherConfig {
    dispatcherValue: "subscribe"
}
remote function onSubscribeMessage(Subscribe message) returns string {
    return "onSubscribeMessage";
}

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

@codecov
Copy link

codecov bot commented Apr 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.42%. Comparing base (8acf0c3) to head (54cb342).
Report is 9 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1566      +/-   ##
============================================
- Coverage     82.45%   82.42%   -0.04%     
+ Complexity      603      602       -1     
============================================
  Files            48       48              
  Lines          3124     3124              
  Branches        415      415              
============================================
- Hits           2576     2575       -1     
  Misses          402      402              
- Partials        146      147       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chathushkaayash chathushkaayash marked this pull request as ready for review April 30, 2025 00:35
@chathushkaayash chathushkaayash force-pushed the feat/custom-remote-method-annotation branch from b59bcc6 to 6cf843e Compare April 30, 2025 00:49
chathushkaayash and others added 2 commits April 30, 2025 09:58
Co-authored-by: Thisaru Guruge <thisaru@wso2.com>
Co-authored-by: Thisaru Guruge <thisaru@wso2.com>
@sonarqubecloud
Copy link

@ThisaruGuruge ThisaruGuruge requested a review from ayeshLK April 30, 2025 04:34
@MohamedSabthar MohamedSabthar merged commit 06d1dfd into ballerina-platform:main Apr 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider a more generic name for @websocket:DispatcherMapping annotation to support future extensibility

3 participants