Add semantic search configs for Azure Knowledgebase#26
Merged
MohamedSabthar merged 4 commits intoballerina-platform:mainfrom Nov 3, 2025
Merged
Conversation
SasinduDilshara
requested review from
MohamedSabthar and
shafreenAnfar
as code owners
SasinduDilshara
force-pushed
the
add-azure-knowledgebase
branch
from
d8a791f to
22b65de
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
- Coverage 28.76% 28.22% -0.54%
==========================================
Files 5 5
Lines 737 751 +14
Branches 223 228 +5
==========================================
Hits 212 212
- Misses 525 539 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| }; | ||
|
|
||
| # Details for semantic configuration in Azure AI Search. | ||
| public type SemanticConfigurationDetails record {| |
Member
There was a problem hiding this comment.
Suggested change
| public type SemanticConfigurationDetails record {| | |
| public type SemanticConfigurations record {| |
| search:ConnectionConfig searchClientConnectionConfig = {}, | ||
| index:ConnectionConfig indexClientConnectionConfig = {}) returns ai:Error? { | ||
| index:ConnectionConfig indexClientConnectionConfig = {}, | ||
| SemanticConfigurationDetails? semanticConfigurationDetails = ()) returns ai:Error? { |
Member
There was a problem hiding this comment.
if the SemanticConfigurationDetails just have the name can't we introduce a string value instead of record?
semanticConfigurationName ?
MohamedSabthar
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add semantic search configs for Azure Knowledgebase