Skip to content

Comments

Mark isLive as isolated#29

Merged
gayaldassanayake merged 2 commits intoballerina-platform:mainfrom
gayaldassanayake:make-islive-isolated
Feb 19, 2026
Merged

Mark isLive as isolated#29
gayaldassanayake merged 2 commits intoballerina-platform:mainfrom
gayaldassanayake:make-islive-isolated

Conversation

@gayaldassanayake
Copy link
Contributor

@gayaldassanayake gayaldassanayake commented Feb 19, 2026

Purpose

Fixes:

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

Changes

This pull request adds the isolated qualifier to the isLive function in the CDC module, updating the function signature from public function isLive(Listener cdc) returns boolean|Error to public isolated function isLive(Listener cdc) returns boolean|Error. This change does not alter the function's logic, parameters, or return type, nor does it affect the underlying Java method binding.

The pull request also includes routine dependency version updates in the manifest file:

  • data.jsondata: 1.1.0 → 1.1.3
  • observe: 1.5.0 → 1.5.1
  • ballerinax/java.jdbc: 1.14.0 → 1.14.1

These are maintenance updates with no behavioral impact on the module.

@coderabbitai
Copy link

coderabbitai bot commented Feb 19, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

This PR updates three dependency versions in Dependencies.toml and adds the isolated keyword to the isLive function in extern_functions.bal to enhance concurrency safety guarantees.

Changes

Cohort / File(s) Summary
Dependency Updates
ballerina/Dependencies.toml
Patch version bumps for data.jsondata (1.1.0 → 1.1.3), observe (1.5.0 → 1.5.1), and ballerinax/java.jdbc (1.14.0 → 1.14.1).
Function Isolation
ballerina/extern_functions.bal
Added isolated keyword to the isLive function signature for stricter concurrency isolation without altering parameters or return type.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • daneshk
  • niveathika

Poem

🐰 Dependencies hop to newer ground,
While isLive gains isolation's sound,
Concurrency locks in place so tight,
Small tweaks that set the module right! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description uses the required template structure but is largely incomplete with all checklist items unchecked and no substantive details provided in any section. Provide context explaining why isLive should be isolated, check relevant checklist items, link to related issues, and document any specification or changelog updates.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: marking the isLive function as isolated, which aligns with the file modifications in extern_functions.bal.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.56%. Comparing base (c241584) to head (e6fdbd6).
⚠️ Report is 7 commits behind head on main.

❌ Your project status has failed because the head coverage (76.56%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #29   +/-   ##
=========================================
  Coverage     76.56%   76.56%           
  Complexity      224      224           
=========================================
  Files            30       30           
  Lines          1084     1084           
  Branches        170      170           
=========================================
  Hits            830      830           
  Misses          176      176           
  Partials         78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gayaldassanayake gayaldassanayake merged commit f100cc4 into ballerina-platform:main Feb 19, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants