Skip to content

Comments

Initiated main repo , Did 4 test cases, Docs done#2

Merged
MohamedSabthar merged 30 commits intoballerina-platform:mainfrom
harithmaduranga:main
Jan 17, 2025
Merged

Initiated main repo , Did 4 test cases, Docs done#2
MohamedSabthar merged 30 commits intoballerina-platform:mainfrom
harithmaduranga:main

Conversation

@harithmaduranga
Copy link
Contributor

@harithmaduranga harithmaduranga commented Jan 6, 2025

Purpose

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@CLAassistant
Copy link

CLAassistant commented Jan 6, 2025

CLA assistant check
All committers have signed the CLA.

@MohamedSabthar
Copy link
Member

@harithmaduranga It's seems like sanitations.md file is missing. Let's add it in the same PR.

Copy link
Member

@MohamedSabthar MohamedSabthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module.md and README.md files are missing. Make sure to add them.

@harithmaduranga
Copy link
Contributor Author

Module.md and README.md files are missing. Make sure to add them.

README.md Outdated
Comment on lines 11 to 14
[HubSpot](https://www.hubspot.com/) is an customer platform with all the software, integrations, and resources users need to connect thier marketing, sales, and customer service.

The `ballerinax/hubspot.crm.commerce.quotes` package offers APIs to connect and interact with [HubSpot API for CRM Quotes](https://developers.hubspot.com/docs/reference/api/crm/commerce/quotes) endpoints, specifically based on [HubSpot CRM Quotes REST API](https://developers.hubspot.com/docs/reference/api).

Copy link
Member

@MohamedSabthar MohamedSabthar Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[HubSpot](https://www.hubspot.com/) is an customer platform with all the software, integrations, and resources users need to connect thier marketing, sales, and customer service.
The `ballerinax/hubspot.crm.commerce.quotes` package offers APIs to connect and interact with [HubSpot API for CRM Quotes](https://developers.hubspot.com/docs/reference/api/crm/commerce/quotes) endpoints, specifically based on [HubSpot CRM Quotes REST API](https://developers.hubspot.com/docs/reference/api).
[HubSpot](https://www.hubspot.com) is an AI-powered customer relationship management (CRM) platform.
The `ballerinax/hubspot.crm.commerce.quotes` offers APIs to connect and interact with the [HubSpot Quotes API](https://developers.hubspot.com/docs/reference/api/crm/commerce/quotes) endpoints, specifically based on the [HubSpot REST API](https://developers.hubspot.com/docs/reference/api).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems your are not using the provided template. Please update in module.md and package.md as well.

@MohamedSabthar MohamedSabthar merged commit b6efd02 into ballerina-platform:main Jan 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants