Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ballerina/Ballerina.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ distribution = "2201.11.0"
graalvmCompatible = true

[[platform.java21.dependency]]
path = "../native/build/libs/jaeger-extension-native-1.1.0-SNAPSHOT.jar"
path = "../native/build/libs/jaeger-extension-native-1.1.0.jar"
groupId = "ballerina"
artifactId = "jaeger-extension-native"
version = "1.1.0-SNAPSHOT"
version = "1.1.0"
Comment on lines 26 to +30
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Locate where the native artifact name/version is set
find . -path ./.*  -prune -o -type f \( -name "build.gradle" -o -name "build.gradle.kts" -o -name "gradle.properties" \) -print | grep native | head -20

echo "---"

# Search for native build configuration
find . -path ./.*  -prune -o -type d -name "native" -print | head -5

echo "---"

# Check gradle.properties for version
if [ -f gradle.properties ]; then
  echo "=== Root gradle.properties ==="
  grep -n "version" gradle.properties
fi

echo "---"

# Find native-specific gradle files
find . -name "*.gradle*" -path "*/native/*" -type f | head -10

Repository: ballerina-platform/module-ballerinax-jaeger

Length of output: 420


🏁 Script executed:

# Check for native build configuration and version references
rg -l "jaeger-extension-native" --type-list --type gradle 2>/dev/null | head -10
rg "jaeger-extension-native|archiveBaseName|version\s*=" --type gradle -A 2 -B 2 | head -50

Repository: ballerina-platform/module-ballerinax-jaeger

Length of output: 1830


🏁 Script executed:

# Look for native build.gradle or build.gradle.kts
find . -path "*/native/*" -name "build.gradle*" -type f -exec cat -n {} +

Repository: ballerina-platform/module-ballerinax-jaeger

Length of output: 6528


Update jar path and version to match native artifact naming.
The native artifact's version is set to project.version (native/build.gradle:122), which is 1.1.1-SNAPSHOT. The jar will be built as jaeger-extension-native-1.1.1-SNAPSHOT.jar, but Ballerina.toml hardcodes 1.1.0. Update the path and version to 1.1.1-SNAPSHOT to match the actual native artifact.

🤖 Prompt for AI Agents
In `@ballerina/Ballerina.toml` around lines 26 - 30, The Ballerina.toml dependency
uses the wrong native artifact name and version; update the path string
"../native/build/libs/jaeger-extension-native-1.1.0.jar" and the version value
"1.1.0" to the actual native artifact name and version
"jaeger-extension-native-1.1.1-SNAPSHOT.jar" and "1.1.1-SNAPSHOT" respectively
so the [[platform.java21.dependency]] entry (path, artifactId =
"jaeger-extension-native", version) matches the native/build.gradle produced
artifact.


[[platform.java21.dependency]]
path = "./lib/opentelemetry-sdk-trace-1.32.0.jar"
Expand Down
21 changes: 18 additions & 3 deletions ballerina/Dependencies.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@

[ballerina]
dependencies-toml-version = "2"
distribution-version = "2201.12.0"
distribution-version = "2201.11.0"

Comment on lines 6 to 9
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

rg -n "distribution-version|ballerinaLangVersion|distribution\s*=" -S

Repository: ballerina-platform/module-ballerinax-jaeger

Length of output: 1227


🏁 Script executed:

cat -n ballerina/Dependencies.toml | head -20

Repository: ballerina-platform/module-ballerinax-jaeger

Length of output: 703


🏁 Script executed:

cat -n gradle.properties | head -25

Repository: ballerina-platform/module-ballerinax-jaeger

Length of output: 1175


Investigate version mismatch in auto-generated Dependencies.toml.
The distribution-version in ballerina/Dependencies.toml is 2201.11.0, while gradle.properties declares ballerinaLangVersion=2201.12.0. Since Dependencies.toml is auto-generated (per its header comment), the concern is why the generation process creates a mismatched version. Additionally, ballerina-tests/jaeger-server-tests/Dependencies.toml declares 2201.12.0, creating inconsistency across the project. Verify whether this mismatch is intentional or if the version alignment needs to be corrected at the generation source.

🤖 Prompt for AI Agents
In `@ballerina/Dependencies.toml` around lines 6 - 9, The auto-generated
ballerina/Dependencies.toml has distribution-version "2201.11.0" that conflicts
with gradle.properties' ballerinaLangVersion=2201.12.0 and with
ballerina-tests/jaeger-server-tests/Dependencies.toml; investigate the
generation source (the script or Gradle task that writes Dependencies.toml),
update it to read the canonical version from gradle.properties
(ballerinaLangVersion) or the centralized version variable, then regenerate
Dependencies.toml so distribution-version matches 2201.12.0 (or intentionally
document why it should differ) and ensure all other generated Dependencies.toml
files (e.g., in ballerina-tests/jaeger-server-tests) are produced from the same
source/version to restore consistency.

[[package]]
org = "ballerina"
name = "io"
version = "1.8.0"
version = "1.7.0"
dependencies = [
{org = "ballerina", name = "jballerina.java"},
{org = "ballerina", name = "lang.value"}
Expand All @@ -35,10 +35,24 @@ dependencies = [
{org = "ballerina", name = "jballerina.java"}
]

[[package]]
org = "ballerina"
name = "log"
version = "2.11.0"
dependencies = [
{org = "ballerina", name = "io"},
{org = "ballerina", name = "jballerina.java"},
{org = "ballerina", name = "lang.value"},
{org = "ballerina", name = "observe"}
]
modules = [
{org = "ballerina", packageName = "log", moduleName = "log"}
]

[[package]]
org = "ballerina"
name = "observe"
version = "1.6.0"
version = "1.4.0"
dependencies = [
{org = "ballerina", name = "jballerina.java"}
]
Expand All @@ -54,6 +68,7 @@ version = "1.1.0"
dependencies = [
{org = "ballerina", name = "io"},
{org = "ballerina", name = "jballerina.java"},
{org = "ballerina", name = "log"},
{org = "ballerina", name = "observe"}
]
modules = [
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

group=org.ballerinalang
version=1.1.0-SNAPSHOT
version=1.1.1-SNAPSHOT
ballerinaLangVersion=2201.12.0
org.gradle.caching=true
org.gradle.parallel=true
Expand Down
Loading