Introduce support for liveness check for MSSQL CDC listener#1168
Introduce support for liveness check for MSSQL CDC listener#1168gayaldassanayake merged 4 commits intoballerina-platform:mainfrom
Conversation
📝 WalkthroughWalkthroughRefactors internal listener configuration to use Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@gradle.properties`:
- Line 33: The gradle property stdlibCdcVersion is set to an
internal/timestamped build (1.2.0-20260213-180200-2268a4d) which is not
published; change the value of stdlibCdcVersion to a published release (e.g.,
1.0.3) so dependency resolution succeeds, or if the internal build is required,
add/configure the custom Maven repository where that artifact is hosted and
document this in the build configuration; update the stdlibCdcVersion entry
accordingly and ensure any repo settings used by Gradle are committed alongside
it.
🧹 Nitpick comments (1)
ballerina/cdc_listener.bal (1)
52-56: Add tests for livenessInterval propagation.Please add/extend tests to assert that
livenessIntervalis included in the final listener config (including default/disabled scenarios).
| observeInternalVersion=1.5.0 | ||
|
|
||
| stdlibCdcVersion=1.0.2 | ||
| stdlibCdcVersion=1.2.0-20260213-180200-2268a4d |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
ballerinax CDC 1.2.0-20260213-180200-2268a4d published artifact
💡 Result:
I couldn’t find any publicly published artifact (Ballerina Central or otherwise indexed by web search) for ballerinax/cdc with the exact version 1.2.0-20260213-180200-2268a4d.
What is publicly visible on Ballerina Central right now is:
ballerinax/cdclatest =1.0.3(and the “Other versions” list shown there does not include any1.2.0-*build) [1].- Related CDC components (e.g.,
ballerinax/mysql.cdc.driver) show latest versions like1.0.1, not1.2.0-*[2].
So that 1.2.0-20260213-180200-2268a4d identifier looks like an internal/nightly/CI build tag rather than a version that has been published to a public package repository.
Sources: [1], [2]
Replace the unstaged CDC version with a published release.
The version 1.2.0-20260213-180200-2268a4d is not published in any public repository. Ballerina Central shows ballerinax/cdc latest as 1.0.3. This timestamped identifier appears to be an internal/nightly build tag that will cause dependency resolution failures. Use a published version like 1.0.3 or configure a custom repository if this internal version is intentional.
🤖 Prompt for AI Agents
In `@gradle.properties` at line 33, The gradle property stdlibCdcVersion is set to
an internal/timestamped build (1.2.0-20260213-180200-2268a4d) which is not
published; change the value of stdlibCdcVersion to a published release (e.g.,
1.0.3) so dependency resolution succeeds, or if the internal build is required,
add/configure the custom Maven repository where that artifact is hosted and
document this in the build configuration; update the stdlibCdcVersion entry
accordingly and ensure any repo settings used by Gradle are committed alongside
it.
fdd727b
into
ballerina-platform:main
Purpose
Part of: ballerina-platform/ballerina-library#8589
Checklist
Summary
Adds liveness check support to the MSSQL CDC listener by extending internal listener configuration to include a configurable livenessInterval and refactoring how configurations are assembled and stored.
Changes
Liveness support and configuration refactor:
Dependency and packaging updates:
Impact