Generate JSON schema dynamically at runtime#21
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (69.89%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## test-runtime-schme #21 +/- ##
======================================================
- Coverage 72.58% 69.89% -2.69%
======================================================
Files 6 6
Lines 186 186
Branches 53 53
======================================================
- Hits 135 130 -5
- Misses 51 56 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…allerinax-np into union-type # Conflicts: # ballerina/Dependencies.toml
2b1e663 to
dae5175
Compare
|
Got the ballerina-platform/ballerina-library#7704 issue |
d39a920
into
ballerina-platform:test-runtime-schme
| } | ||
|
|
||
| @Override | ||
| public FunctionCallExpressionNode transform(FunctionCallExpressionNode functionCallExpressionNode) { |
There was a problem hiding this comment.
Why didn't we do this only for np:callLlm calls?
There was a problem hiding this comment.
You mean to special case only for np:callLlm, right? There's no issue with the current implementation, right?it's to analyze all function calls.
There was a problem hiding this comment.
Aren't we unnecessarily generating JSON schema with function calls that are not relevant to NP?
E.g.,
import ballerinax/np; // used elsewhere in the file, but no reference to IntArray
type IntArray int[];
function getArr() returns IntArray => [1, 2];
IntArray x = getArr();There was a problem hiding this comment.
Purpose
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning