Handle error message for parse errors#37
Merged
SasinduDilshara merged 4 commits intoballerina-platform:mainfrom Mar 17, 2025
Merged
Handle error message for parse errors#37SasinduDilshara merged 4 commits intoballerina-platform:mainfrom
SasinduDilshara merged 4 commits intoballerina-platform:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (72.58%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 63.79% 72.58% +8.78%
==========================================
Files 6 6
Lines 174 186 +12
Branches 50 53 +3
==========================================
+ Hits 111 135 +24
+ Misses 63 51 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chiranSachintha
approved these changes
Mar 17, 2025
SasinduDilshara
merged commit f9b959b
into
ballerina-platform:main
3 of 4 checks passed
SasinduDilshara
commented
Mar 17, 2025
|
|
||
| const JSON_CONVERSION_ERROR = "FromJsonStringError"; | ||
| const CONVERSION_ERROR = "ConversionError"; | ||
| const ERROR_MESSAGE = "Error occurred while converting the LLM response to the given type. Please refined your prompt to get a better result."; |
Contributor
Author
There was a problem hiding this comment.
@MaryamZi Can you review this error message?
MaryamZi
reviewed
Mar 25, 2025
| return result; | ||
| } | ||
|
|
||
| isolated function handlepParseResponseError(error chatResponseError) returns error { |
| isolated function handlepParseResponseError(error chatResponseError) returns error { | ||
| if chatResponseError.message().includes(JSON_CONVERSION_ERROR) | ||
| || chatResponseError.message().includes(CONVERSION_ERROR) { | ||
| return error(string `${ERROR_MESSAGE}`); |
Member
There was a problem hiding this comment.
Why isn't this just
return error(ERROR_MESSAGE);
Comment on lines
+2
to
+4
| import ballerinax/azure.openai.chat as azureOpenAIChat; | ||
| import ballerinax/openai.chat as openAIChat; | ||
| import ballerina/test; |
Comment on lines
+16
to
+17
| anydata content = message["content"]; | ||
| string contentStr = content.toString(); |
Member
There was a problem hiding this comment.
Use ensureType appropriately instead of just taking toString.
| return "INVALID"; | ||
| } | ||
|
|
||
| isolated function getTheMockLLMResult(string message) returns string { |
| } | ||
|
|
||
| if message.startsWith("What is 1 + 1?") { | ||
| return expectedPromptStringForRateBlog3; |
Member
There was a problem hiding this comment.
Why is this variable name rateBlog?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ballerina-platform/ballerina-library#7695