Add the sportsperson sample#47
Closed
MaryamZi wants to merge 0 commit intoballerina-platform:mainfrom
Closed
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project check has failed because the head coverage (69.89%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
=======================================
Coverage 69.89% 69.89%
=======================================
Files 6 6
Lines 186 186
Branches 53 53
=======================================
Hits 130 130
Misses 56 56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| io:println("Born in: ", person.yearOfBirth); | ||
| io:println("Sport: ", person.sport); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Lets handle the error and null scenarios as well, for the completeness of the example
Member
Author
There was a problem hiding this comment.
check is good enough for error IMO. Added an else block for nil. New PR - #49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
$title.