Skip to content

Comments

Ensure parent directories are created when writing driver import file#434

Merged
daneshk merged 1 commit intomainfrom
fix-driver-file
Dec 3, 2025
Merged

Ensure parent directories are created when writing driver import file#434
daneshk merged 1 commit intomainfrom
fix-driver-file

Conversation

@TharmiganK
Copy link
Contributor

Purpose

$Subject

Examples

N/A

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2025

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds safety logic to ensure parent directories exist before writing the driver import file. The change prevents potential FileNotFoundException when the output path's parent directories don't exist.

Key Changes:

  • Added directory creation check in writeOutputFile method to create parent directories if they don't exist

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.96%. Comparing base (f51455c) to head (321c00f).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...allerina/persist/nodegenerator/DriverResolver.java 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
- Coverage   85.98%   85.96%   -0.03%     
==========================================
  Files          68       68              
  Lines        6593     6596       +3     
  Branches      880      881       +1     
==========================================
+ Hits         5669     5670       +1     
- Misses        661      662       +1     
- Partials      263      264       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@daneshk daneshk merged commit 21ac485 into main Dec 3, 2025
12 of 13 checks passed
@TharmiganK TharmiganK deleted the fix-driver-file branch December 3, 2025 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants