Remove groupByClause from SQL resource function signature for eager loading#439
Merged
TharmiganK merged 2 commits intomainfrom Dec 19, 2025
Merged
Remove groupByClause from SQL resource function signature for eager loading#439TharmiganK merged 2 commits intomainfrom
TharmiganK merged 2 commits intomainfrom
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
==========================================
+ Coverage 85.83% 85.84% +0.01%
==========================================
Files 68 68
Lines 6665 6670 +5
Branches 889 890 +1
==========================================
+ Hits 5721 5726 +5
Misses 677 677
Partials 267 267 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
daneshk
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Purpose
The
groupByparameter is not useful in the get all methods because that option is often used with aggregate functions and the result may change based on the aggregation and it will be never bind to stream/array of row type.This we need to fix in the persist tool. For now, we are removing it for eager loading scenarios which will be used by BI
Examples
Checklist