Skip to content

Comments

Remove groupByClause from SQL resource function signature for eager loading#439

Merged
TharmiganK merged 2 commits intomainfrom
remove-group-by
Dec 19, 2025
Merged

Remove groupByClause from SQL resource function signature for eager loading#439
TharmiganK merged 2 commits intomainfrom
remove-group-by

Conversation

@TharmiganK
Copy link
Contributor

@TharmiganK TharmiganK commented Dec 18, 2025

Purpose

The groupBy parameter is not useful in the get all methods because that option is often used with aggregate functions and the result may change based on the aggregation and it will be never bind to stream/array of row type.

This we need to fix in the persist tool. For now, we are removing it for eager loading scenarios which will be used by BI

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.84%. Comparing base (f01a5ff) to head (203fa53).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #439      +/-   ##
==========================================
+ Coverage   85.83%   85.84%   +0.01%     
==========================================
  Files          68       68              
  Lines        6665     6670       +5     
  Branches      889      890       +1     
==========================================
+ Hits         5721     5726       +5     
  Misses        677      677              
  Partials      267      267              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TharmiganK TharmiganK merged commit 41bf7d9 into main Dec 19, 2025
6 checks passed
@TharmiganK TharmiganK deleted the remove-group-by branch December 19, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants