Fix extra line in generated ballerina source in grpc tool#60
Merged
daneshk merged 2 commits intoballerina-platform:mainfrom Jan 8, 2025
Merged
Conversation
- Resolved an issue where generated source files contained extra trailing newlines. - Updated the writeOutputFile method to ensure only one newline at the end of each generated file. - Added a test case to verify the newline handling.
randilt
requested review from
daneshk,
lnash94 and
shafreenAnfar
as code owners
|
|
daneshk
reviewed
Jan 7, 2025
tooling-tests/src/test/java/io/ballerina/protoc/tools/ToolingCommonTest.java
Show resolved
Hide resolved
Co-authored-by: Danesh Kuruppu <daneshk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves #3953
Examples
Checklist