Add SPM support & migrate to Swift 6.2

[sereivoanyong]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @sereivoanyong, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces Swift Package Manager support and migrates the project to Swift 6.2, aligning with modern Swift development practices. A significant focus has been placed on enhancing concurrency safety by applying the @MainActor attribute to core UI components and their protocol conformances, ensuring thread-safe operations. Additionally, the codebase benefits from increased immutability through the use of let for static OptionSet members and updated protocol declarations to reflect current Swift standards.

Highlights

• Swift Package Manager (SPM) Support: The project now includes full support for Swift Package Manager, making it easier to integrate and manage dependencies.
• Swift 6.2 Migration: The project has been migrated to Swift 6.2, leveraging the latest language features and improvements.
• Concurrency Safety with @mainactor: Key UI-related types such as Cell, CellRange, and LayoutEngine, along with their protocol conformances, have been marked with @MainActor to ensure main-thread execution and enhance concurrency safety.
• Improved Immutability: Static members within OptionSet types like CircularScrolling.Direction, CircularScrolling.TableStyle, and ScrollPosition have been changed from var to let, promoting immutability and safer code.
• Sendable Conformance: The ScrollPosition struct now conforms to the Sendable protocol, indicating that instances of this type can be safely passed across concurrency domains.
• Modernized Protocol Declarations: Protocol declarations for SpreadsheetViewDataSource and SpreadsheetViewDelegate have been updated to use AnyObject instead of the deprecated class keyword for class-only protocols.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request does a great job of adding Swift Package Manager support and migrating the codebase to Swift 6.2. The changes to adopt Swift 6's concurrency features, like using @MainActor for UI-related classes and adding Sendable conformance, are well-executed and necessary for modern Swift development. The updates from var to let for static constants and class to AnyObject for protocols are also good practice.

My main feedback is on the new Package.swift file. I've suggested adding platform specifications and including the existing test suite to make the SPM package more robust and easier for other developers to use.

[gemini-code-assist]

This is a great start for adding Swift Package Manager support! To make the package manifest more complete and useful for developers, I have a couple of suggestions:

1. Specify Supported Platforms: Since this library uses UIKit, it's specific to Apple platforms like iOS. It's a good practice to explicitly declare the supported platforms and minimum deployment versions. Based on the usage of APIs like safeAreaInsetsDidChange, it seems iOS 11 would be a safe minimum target.

2. Include a Test Target: The repository contains tests under Framework/Tests. These should be included in the Package.swift file so they can be run easily using SPM.

I've included a code suggestion that incorporates these changes.

Suggested change

	// swift-tools-version: 6.2
	import PackageDescription
	let package = Package(
	name: "SpreadsheetView",
	products: [
	.library(name: "SpreadsheetView", targets: ["SpreadsheetView"]),
	],
	targets: [
	.target(name: "SpreadsheetView", path: "Framework/Sources"),
	]
	)
	// swift-tools-version: 6.2
	import PackageDescription
	let package = Package(
	name: "SpreadsheetView",
	platforms: [
	.iOS(.v11)
	],
	products: [
	.library(name: "SpreadsheetView", targets: ["SpreadsheetView"]),
	],
	targets: [
	.target(name: "SpreadsheetView", path: "Framework/Sources"),
	.testTarget(
	name: "SpreadsheetViewTests",
	dependencies: ["SpreadsheetView"],
	path: "Framework/Tests")
	]
	)