ShowFormPageAction should not continue with form errors#146
Open
peppage wants to merge 1 commit intobartverdonck:feature/9.0from
Open
ShowFormPageAction should not continue with form errors#146peppage wants to merge 1 commit intobartverdonck:feature/9.0from
peppage wants to merge 1 commit intobartverdonck:feature/9.0from
Conversation
This shouldn't continue to the next page if something in the process has caused an error before it. For example if a previous submit action fails the user might want to try and submit the form again. We wouldn't want them to assume everything is working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The save action shouldn't continue to the next page if something in the process
has caused an error before it.
For example if a previous submit action fails the user might want to
try and submit the form again. We wouldn't want them to assume
everything is working.
I branched off 9.0 because that's the only one I can test but I think it should be merged into all versions