Add vertical distance for vertical cover#369
Open
sh-nguyen wants to merge 1 commit intobasbruss:mainfrom
Open
Conversation
Add option to specify the vertical distance from the workarea to the base of the fully extended vertical cover.
carterbox
reviewed
Feb 23, 2025
| "data": { | ||
| "set_azimuth": "Window Azimuth", | ||
| "window_height": "Window Height", | ||
| "window_position": "Window Position", |
Contributor
There was a problem hiding this comment.
You should add a longer description of this new parameter in the "data_description" section so that it appears in the HA GUI during configuration. Then users don't have to come to GitHub and scroll through the README to figure out the meaning of this new parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add option to specify the vertical distance from the workarea to the base of the fully extended vertical cover.
Description
Add new Window position variable that is used in calculating the position of the window.
Motivation and Context
This allows the workarea to be on a different plane to the bottom of the fully extended vertical cover.
How has this been tested?
Tested the formula change via simulation, and the integration via real world testing of two window shades that are different lengths mounted at the same height above the floor. Have confirmed that the bottom of the shades are level with each other throughout the day, when other parameters are kept the same.
Screenshots (if appropriate):
Types of changes
Checklist