Add XML custom loader overrides #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holywyvern
force-pushed
the
feature-xml_reader_override
branch
from
4b36973 to
aa3aca5
Compare
Owner
|
Hello, thank you for your contribution. Sorry for the very late response 😨 I do not want to expose anything from libxml2 in libtmx, so I'm not merging it. |
holywyvern
force-pushed
the
feature-xml_reader_override
branch
from
e24b546 to
4c2a442
Compare
Author
Sure, I'll still keep it the branch updated if someone requires this for some reason. |
baylej
force-pushed
the
master
branch
12 times, most recently
from
cff450c to
3032fe4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the
xmlReaderForFileandxmlFreeTextReaderto use instead tmx custom functions instead.This allows to use PhysFS or other virtual filesystems without much trouble.
I attempted to copy the style used for
tmx_img_load_funcandtmx_img_free_funcas much as I could.To override this functions and to keep old headers intact, you should require "tmx_xml.h" first.