Conversation
Collaborator
|
I think if we go this route, we should make it a first class citizen in the README (and the docs) on how to actually do a patch correctly. I'm not a huge fan of patches because the patches themselves are not human readable. In this case it works becuase the output is human readable: the resulting mdx file. |
Collaborator
|
What I mean by human readable is: they are not the easiest thing to grok for the untrained eye. |
Collaborator
Author
|
If we allow patches, I imagine the script would actually diff the upstream/ submodule against origin, and update all the patches for you, like https://github.com/ds300/patch-package But this example with a isn't a great motivation since it's not that hard to automate this translation. I'm fine not merging this and we can discuss more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow a controlled way for content on the site to diverge from bazelbuild/bazel repo.
This relaxes how complete our translation from Jekyll and HTML needs to be. In this example I manually fix a
<table>tag, which means we don't have to create an automated replacement.The size of the patch file makes it obvious whether we are diverging too much, versus a fork of the repo where the git history hides the delta from upstream.
Issues: