Ensure that data from code_libraries are included#262
Open
dbanetto wants to merge 2 commits intobazel-contrib:masterfrom
Open
Ensure that data from code_libraries are included#262dbanetto wants to merge 2 commits intobazel-contrib:masterfrom
data from code_libraries are included#262dbanetto wants to merge 2 commits intobazel-contrib:masterfrom
Conversation
dbanetto
commented
Sep 30, 2025
| @@ -502,7 +508,9 @@ def _jsonnet_to_json_test_impl(ctx): | |||
| transitive_data = depset( | |||
| transitive = [dep.data_runfiles.files for dep in ctx.attr.deps] + | |||
Contributor
Author
There was a problem hiding this comment.
🤔 Is there a reason that the jsonnet_ext_code_files & jsonnet_ext_str_files are not included here?
0c18a95 to
9138915
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When a
jsonnet_librarydefined adatadependency and thejsonnet_librarywas included in a{tla,ext}_code_libraries(See updated//:extvar_code_library_test) thedatawas not being included which results in error like:Digging into the sandbox, the
datafile (files.txtin the example//:extvar_code_library_test) looks like:Resolution
Adding the missing addition of the
data_runfilesto thetransitive_datainjsonnet_to_json{,_test}.Updated the example to make use of this as well.