Make cc_library(alwayslink=True) apply to .a in srcs#574
Open
keith wants to merge 1 commit intobazelbuild:mainfrom
Open
Make cc_library(alwayslink=True) apply to .a in srcs#574keith wants to merge 1 commit intobazelbuild:mainfrom
keith wants to merge 1 commit intobazelbuild:mainfrom
Conversation
keith
requested review from
armandomontanez,
c-mita,
hvadehra,
pzembrod and
trybka
as code owners
Member
Author
|
I'm curious to hear from folks with more context on if this is a good idea to change. previously if you had both |
Member
Author
|
i will exclude from CI if we get consensus on this being a good idea |
Previously if you had an archive in the srcs of a cc_library and set alwayslink=True that was ignored. You had to have named the library .lo (arguably an implementation detail) to get the desired behavior.
keith
force-pushed
the
ks/make-cc_library-alwayslink-true-apply-to-.a-in-srcs
branch
from
7dcb1ba to
e80ce8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if you had an archive in the srcs of a cc_library and set
alwayslink=True that was ignored. You had to have named the library .lo
(arguably an implementation detail) to get the desired behavior.