Add rules_zig to the Starlarkification allowlist#589
Open
aherrmann wants to merge 1 commit intobazelbuild:mainfrom
Open
Add rules_zig to the Starlarkification allowlist#589aherrmann wants to merge 1 commit intobazelbuild:mainfrom
aherrmann wants to merge 1 commit intobazelbuild:mainfrom
Conversation
rules_zig needs to invoke `cc_common.link` with the `main_output` parameter when users request linking via the C toolchain. See motivation in aherrmann/rules_zig#519 (comment). rules_zig used to work around this issue with the same hack that rules_rust and rules_mojo applied, but this is no longer available as of Bazel 9.0.0, see aherrmann/rules_zig#589.
aherrmann
requested review from
armandomontanez,
c-mita,
hvadehra,
pzembrod and
trybka
as code owners
This was referenced Feb 4, 2026
Author
|
The CI failure may be unrelated: |
Collaborator
Member
|
this is a good idea, if this is preferred by googlers I will submit a similar PR for rules_mojo |
Collaborator
|
If I get pushback on approving #578 then I will approve this and a similar one for rules_mojo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rules_zig needs to invoke
cc_common.linkwith themain_outputparameter when users request linking via the C toolchain. Motivation for this linking mode is provided in aherrmann/rules_zig#519. The need for access to themain_outputparameter is motivated in aherrmann/rules_zig#519 (comment).rules_zig used to work around this issue with the same hack that rules_rust and rules_mojo applied, but this is no longer available as of Bazel 9.0.0, see aherrmann/rules_zig#589. As described in bazelbuild/bazel#23838 (comment) there does not seem to be any other work around available. So, I would like to request to add rules_zig to the list of rule sets that are allowed to use the private
cc_common.linkAPI.Note, this is a blocker for Bazel 9.0.0 support in rules_zig, see aherrmann/rules_zig#592.