Add extra_exec_rustc_flags_triples, extra_exec_rustc_flags_exec_triples and extra_rustc_flags_exec_triples#3811
Open
jesses-canva wants to merge 1 commit intobazelbuild:mainfrom
Conversation
…es and extra_rustc_flags_exec_triples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extra_exec_rustc_flags_triplesis just theexecversion ofextra_rustc_flags_triples. We don't strictly needed this but seemed like a strange omission (you may want to vary flags with the target triple in the exec configuration).extra_exec_rustc_flags_exec_triplesandextra_rustc_flags_exec_triplesare likeextra_exec_rustc_flags_triplesandextra_rustc_flags_triples, except instead of being indexed by the target triple, they are indexed by the execution triple.We need this to pass
-Clink-self-contained=no, which is only valid whenrustcis running onx86_64-unknown-linux-gnu.