Add needed features for hermetic builds on linux.#1627
Open
sayrer wants to merge 1 commit intobazelbuild:mainfrom
Open
Add needed features for hermetic builds on linux.#1627sayrer wants to merge 1 commit intobazelbuild:mainfrom
sayrer wants to merge 1 commit intobazelbuild:mainfrom
Conversation
Contributor
|
FYI; I was actually working on something similar that I just posted here: #1630. |
Author
|
Not attached to any given solution. Here's how I use this patch (with a patchfile applied in MODULE.bazel): https://github.com/sayrer/twitter-text/tree/main/tools/swift I didn't do the Apple path, because those are by definition not hermetic, right? They always depend on the local machine. But if that big patch in #1630 works for me (RBE on Ubuntu 24.04), I'm fine with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/common/process.cc** - Keep full path in argv[0]2.
swift/toolchains/swift_toolchain.bzl- Enable sandboxed builds with hermetic toolchaintoolchain_filesattribute to pass toolchain files as tracked dependenciestoolchain_filestoadditional_toolsfor compile actionstoolchain_filestoadditional_inputsin linker'sCcInfoI ran the tests, and got some failures, but they were the same as on the main branch. I'm not attached to this approach, but it works for me. Here's an excerpt from my MODULE.bazel: