Allow specifying project name in the dirconfig file#1801
Allow specifying project name in the dirconfig file#1801Thuna-Cing wants to merge 3 commits intobbatsov:masterfrom
Conversation
* projectile.el (projectile-dirconfig-name-prefix): Add option. (projectile-project-default-project-name): Use the project name in dirconfig when given, use the directory name otherwise. (projectile-parse-dirconfig-file): Parse and return the project name as the fourth element.
* test/projectile-test.el (projectile-parse-dirconfig-file): Expect the fourth element representing the project name. This is just to make sure the tests succeed. A proper test for project names should be written.
|
Isn't it much easier to set a custom project name using |
|
|
But at the cost of adding more complexity to an already complex thing. That's why I'm a bit on the fence about this. I wonder if it won't be simpler to introduce a new file like |
|
Does projectile use (or intend to use) any information other than the project name? If it will also contain the projectile configuration in Besides, if we have so much information that a different projectile-specific file is necessary, I would lean more toward making |
|
At some point I was thinking of making some more structured configuration file to replace |
projectile.el
Outdated
| The project name is based on the value of PROJECT-ROOT." | ||
| (file-name-nondirectory (directory-file-name project-root))) | ||
| (or (let ((default-directory project-root)) | ||
| (nth 3 (projectile-parse-dirconfig-file))) |
There was a problem hiding this comment.
As the project name is constantly recalculated in the modeline parsing the config file all the time can make things extremely slow. That's one more reason I'm wary about the proposed change.
* projecile.el (projectile-default-project-name): Search only for the name instead of calling `projectile-parse-dirconfig-file' everytime.
|
Hmm, I didn't realize just how often |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed soon if no further activity occurs. Thank you for your contribution and understanding! |
This allows specifying the project name in the .projectile file.
It is backwards compatible as the older versions will parse the name as a comment.
All tests except one that also fails on origin are passing so I marked them as such.
There should be a new test added to actually check that the project name is being
parsed properly but it can wait until the rest of the change is finalized, similarly for the
readme and the changelog.
Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test)M-x checkdocwarnings