fix: CCP-1585 Refactor ExternalAPIs.vue to use <script setup> and add unit tests#1797
Open
jasonchung1871 wants to merge 6 commits intobcgov:mainfrom
Open
fix: CCP-1585 Refactor ExternalAPIs.vue to use <script setup> and add unit tests#1797jasonchung1871 wants to merge 6 commits intobcgov:mainfrom
jasonchung1871 wants to merge 6 commits intobcgov:mainfrom
Conversation
Migrates ExternalAPIs.vue from Options API to Composition API with <script setup>, improving code clarity and reactivity. Updates language handling to use the i18n composable and refactors form validation and dialog logic. Adds a comprehensive unit test suite for ExternalAPIs.vue to ensure correct behavior of API calls, notifications, and form actions.
jasonchung1871
changed the title
Added error messages to appease SonarQube
Replaced inline Vuetify component stubs with a shared vuetifyStub import in the ExternalAPIs.spec.js test file to reduce duplication and improve maintainability.
jasonchung1871
requested review from
RyanBirtch-aot,
nimya-aot and
usingtechnology
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates ExternalAPIs.vue from Options API to Composition API with <script setup>, improving code clarity and reactivity. Updates language handling to use the i18n composable and refactors form validation and dialog logic. Adds a comprehensive unit test suite for ExternalAPIs.vue to ensure correct behavior of API calls, notifications, and form actions.
Type of Change
This is just some technical debt
Checklist
Further comments