Skip to content

Feature/devsu 2815 make create report access project specific #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sshugsc wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Feature/devsu 2815 make create report access project specific #475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d69cab
add user project check when creating report
sshugsc Jan 29, 2026
d3fb61b
lint
sshugsc Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions app/routes/report/report.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,23 @@ router.route('/')
const {
query: {ignore_extra_fields, upload_contents},
} = req;

let userProjects;
try {
userProjects = await getUserProjects(db.models.project, req.user);
userProjects = userProjects.map((proj) => {
return proj.name;
});
} catch (error) {
const message = `Error while trying to get project access ${error}`;
logger.error(message);
return res.status(HTTP_STATUS.INTERNAL_SERVER_ERROR).json({error: {message}});
}

if (req.body.project && !userProjects.includes(req.body.project)) {
return res.status(HTTP_STATUS.FORBIDDEN).json({error: `User does not have access to project ${req.body.project}`});
}

if (req.body.sampleInfo) {
// Clean sampleInfo input
const cleanSampleInfo = [];
Expand Down
18 changes: 17 additions & 1 deletion app/routes/report/reportAsync.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,13 @@ const {v4: uuidv4} = require('uuid');
const reportAsyncMiddleware = require('../../middleware/reportAsync');

const {addJobToReportQueue} = require('../../queue');

const db = require('../../models');
const logger = require('../../log');

const router = express.Router({mergeParams: true});

const validateAgainstSchema = require('../../libs/validateAgainstSchema');
const {getUserProjects} = require('../../libs/helperFunctions');

// Generate schema's
const reportUploadSchema = require('../../schemas/report/reportUpload')(true);
Expand All @@ -24,6 +25,21 @@ router.route('/')
query: {ignore_extra_fields},
} = req;

let userProjects;
try {
userProjects = await getUserProjects(db.models.project, req.user);
userProjects = userProjects.map((proj) => {
return proj.name;
});
} catch (error) {
const message = `Error while trying to get project access ${error}`;
logger.error(message);
return res.status(HTTP_STATUS.INTERNAL_SERVER_ERROR).json({error: {message}});
}

if (req.body.project && !userProjects.includes(req.body.project)) {
return res.status(HTTP_STATUS.FORBIDDEN).json({error: `User does not have access to project ${req.body.project}`});
}
if (req.body.sampleInfo) {
// Clean sampleInfo input
const cleanSampleInfo = [];
Expand Down
Loading