United Kingdom Extensions: Added NHSNumber generator to Person#483
Open
JohnStabler wants to merge 4 commits intobchavez:masterfrom
Open
United Kingdom Extensions: Added NHSNumber generator to Person#483JohnStabler wants to merge 4 commits intobchavez:masterfrom
JohnStabler wants to merge 4 commits intobchavez:masterfrom
Conversation
NHS numbers at 10 digits long. The last digit is a check digit
bchavez
force-pushed
the
master
branch
27 times, most recently
from
9673304 to
97ddbb3
Compare
bchavez
force-pushed
the
master
branch
2 times, most recently
from
0b65acc to
cc799df
Compare
Owner
|
Hi. I think we need a unit test for this. Also, is there a way to generate an NHS number without the Generally, it's a bad/anti-pattern for generators to have a A better implementation would be a straight one-shot generation of the NHS number after calling the generation method. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NHS numbers at 10 digits long. The last digit is a check digit