Skip to content

Conversation

@mikelxc
Copy link

@mikelxc mikelxc commented Jan 17, 2025

This pull request enhances the installation process for the smart contract by bundling all necessary dependencies directly within the repository. This change addresses the current requirement of reading dependencies from node_modules, which necessitates an extra installation step. This also enables direct import of the contracts via soldeer install nexus~1.0.2

Changes Made
• Bundled Dependencies: Moved all required dependencies into a dedicated deps folder within the repository.
• Minimal Modifications: Ensured that changes are minimal and only apply to the v1.0.1 release to maintain compatibility with existing setups.
• Deployment: Deployed the updated contract to the Soldeer Package Manager for seamless access.

Benefits
• Streamlined Installation: Eliminates the need for users to manually install dependencies from node_modules, reducing setup complexity.
• Enhanced Stability: By controlling the dependency versions within the repository, we ensure consistent behavior across different environments.
• Quick Access: Users can easily access the contract through the Soldeer Package Manager without additional configuration steps.

Deployment Details
• Package Manager: Soldeer
• Project Link: https://soldeer.xyz/project/nexus

Notes
• Release Specific: These changes are exclusively for the v1.0.1 release and do not impact other versions.
• Future Releases: Consider adopting a dependency management strategy that minimizes repository size and enhances scalability for future releases.

Please review the changes and provide feedback or approval. Thank you!

@openzeppelin-code
Copy link

Simplify Installation for v1.0.1 by Bundling Dependencies in Repository

Generated at commit: 8dbbf81c9e59b4945f4cfb373fbcc7e77845f6b1

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
1
0
6
26
34

For more details view the full report in OpenZeppelin Code Inspector

@filmakarov
Copy link
Collaborator

hey @mikelxc Thank you for submitting this PR.

I have a couple of questions before merging

  1. Can you describe the problems you had with installing dependencies from deploy-v1.0.1 branch?

  2. Why have you removed scripts/bash-deploy and all according scripts from your branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants