Skip to content

Comments

Fix [L-01] Use namespaced storage in RegistryAdapter#264

Merged
filmakarov merged 1 commit intorelease/v1.2.0from
fix/l-01-namespaced-storage-for-Registry-Adapter
Mar 29, 2025
Merged

Fix [L-01] Use namespaced storage in RegistryAdapter#264
filmakarov merged 1 commit intorelease/v1.2.0from
fix/l-01-namespaced-storage-for-Registry-Adapter

Conversation

@filmakarov
Copy link
Collaborator

@filmakarov filmakarov commented Mar 27, 2025

https://github.com/PashovAuditGroup/Nexus_March25_MERGED/issues/2


PR-Codex overview

This PR focuses on integrating ERC-7484 registry functionality into the RegistryAdapter contract, enhancing how smart accounts can manage and interact with registries for attestation purposes.

Detailed summary

  • Added registry address mapping in IStorage.sol for ERC-7484.
  • Updated getRegistry() function in RegistryAdapter to return the configured registry.
  • Modified _configureRegistry() to store the new registry address in storage.
  • Changed registry variable to use storage in _checkRegistry().
  • Updated test to call getRegistry() instead of directly accessing registry.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@github-actions
Copy link

🤖 Slither Analysis Report 🔎

Slither report

Details # Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - unused-return (2 results) (Medium)

unused-return

🟡 Impact: Medium
🟡 Confidence: Medium

base/ModuleManager.sol#L255-L259

base/ModuleManager.sol#L232-L241

constable-states

Impact: Optimization
🔴 Confidence: High

factory/RegistryFactory.sol#L38

_This comment was automatically generated by the GitHub Actions workflow._

@openzeppelin-code
Copy link

[L-01] Use namespaced storage in RegistryAdapter

Generated at commit: 81c0aedf69e298933339bcbd956b6e3915fe8fe3

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
1
0
7
30
39

For more details view the full report in OpenZeppelin Code Inspector

@filmakarov filmakarov changed the title [L-01] Use namespaced storage in RegistryAdapter Fix [L-01] Use namespaced storage in RegistryAdapter Mar 27, 2025
@filmakarov filmakarov merged commit a1c6808 into release/v1.2.0 Mar 29, 2025
5 of 9 checks passed
@filmakarov filmakarov deleted the fix/l-01-namespaced-storage-for-Registry-Adapter branch March 29, 2025 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant