Fix [L-01] Use namespaced storage in RegistryAdapter#264
Merged
filmakarov merged 1 commit intorelease/v1.2.0from Mar 29, 2025
Merged
Conversation
🤖 Slither Analysis Report 🔎Slither reportDetails# Slither reportTHIS CHECKLIST IS NOT COMPLETE. Use
unused-return🟡 Impact: Medium
base/ModuleManager.sol#L255-L259
base/ModuleManager.sol#L232-L241 constable-statesImpact: Optimization
|
[L-01] Use namespaced storage in RegistryAdapter
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/PashovAuditGroup/Nexus_March25_MERGED/issues/2
PR-Codex overview
This PR focuses on integrating ERC-7484 registry functionality into the
RegistryAdaptercontract, enhancing how smart accounts can manage and interact with registries for attestation purposes.Detailed summary
registryaddress mapping inIStorage.solfor ERC-7484.getRegistry()function inRegistryAdapterto return the configured registry._configureRegistry()to store the new registry address in storage.registryvariable to use storage in_checkRegistry().getRegistry()instead of directly accessingregistry.