Fix [M-01] Hook bypass for module installation via module enable mode

[filmakarov]

Fix https://github.com/PashovAuditGroup/Nexus_March25_MERGED/issues/13

---

PR-Codex overview

This PR focuses on enhancing the ModuleManager and related contracts by refining module installation functionalities, introducing a new EmittingHook contract, and updating interfaces for better modular management.

Detailed summary

• Added installModule, uninstallModule, and isModuleInstalled functions in NexusBootstrap.
• Updated IERC7579Account interface to remove IModuleManager.
• Changed assertions in tests to use IModuleManager.
• Enhanced installModule method in Nexus to be virtual override.
• Introduced EmittingHook contract with various event emissions.
• Updated ModuleManager to utilize IModuleManager.
• Added a new test for module recognition by hooks in TestModuleManager_EnableMode.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[github-actions]

🤖 Slither Analysis Report 🔎

Slither report

Details

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - unused-return (2 results) (Medium)

• constable-states (2 results) (Optimization)

unused-return

🟡 Impact: Medium
🟡 Confidence: Medium

• ID-0
  ModuleManager._uninstallExecutor(address,bytes) ignores return value by executor.excessivelySafeCall(gasleft()(),0,0,abi.encodeWithSelector(IModule.onUninstall.selector,disableModuleData))

base/ModuleManager.sol#L256-L260

• ID-1
  ModuleManager._uninstallValidator(address,bytes) ignores return value by validator.excessivelySafeCall(gasleft()(),0,0,abi.encodeWithSelector(IModule.onUninstall.selector,disableModuleData))

base/ModuleManager.sol#L233-L242

constable-states

Impact: Optimization
🔴 Confidence: High

• ID-2
  RegistryAdapter.registry should be constant

base/RegistryAdapter.sol#L10

• ID-3
  RegistryFactory.threshold should be constant

factory/RegistryFactory.sol#L38

_This comment was automatically generated by the GitHub Actions workflow._

[openzeppelin-code]

Fix [M-01] Hook bypass for module installation via module enable mode

Generated at commit: 5af7aa8fc33f3378d972de2162a4def5f5aa78aa

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	1 1 0 7 30 39

---

For more details view the full report in OpenZeppelin Code Inspector