Fix [L-13] bypassing hooking with bootstrap

[filmakarov]

Fix https://github.com/PashovAuditGroup/Nexus_March25_MERGED/issues/17

---

PR-Codex overview

This PR focuses on modifying the ModuleManager contract by adding the withHook modifier to various module installation functions, ensuring hooks are properly integrated during module installation processes.

Detailed summary

• Added withHook modifier to the following functions:
  • function _installModule
  • function _installValidator
  • function _installExecutor
  • function _installHook
  • function _installFallbackHandler
• Maintained the existing functionality of each function while enhancing them with the withHook modifier.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[github-actions]

🤖 Slither Analysis Report 🔎

Slither report

Details

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - unused-return (2 results) (Medium)

• constable-states (2 results) (Optimization)

unused-return

🟡 Impact: Medium
🟡 Confidence: Medium

• ID-0
  ModuleManager._uninstallExecutor(address,bytes) ignores return value by executor.excessivelySafeCall(gasleft()(),0,0,abi.encodeWithSelector(IModule.onUninstall.selector,disableModuleData))

base/ModuleManager.sol#L271-L275

• ID-1
  ModuleManager._uninstallValidator(address,bytes) ignores return value by validator.excessivelySafeCall(gasleft()(),0,0,abi.encodeWithSelector(IModule.onUninstall.selector,disableModuleData))

base/ModuleManager.sol#L240-L249

constable-states

Impact: Optimization
🔴 Confidence: High

• ID-2
  RegistryAdapter.registry should be constant

base/RegistryAdapter.sol#L10

• ID-3
  RegistryFactory.threshold should be constant

factory/RegistryFactory.sol#L38

_This comment was automatically generated by the GitHub Actions workflow._