fix: improve banner visibility on light terminal backgrounds#863
Open
HueCodes wants to merge 1 commit intobee-san:masterfrom
Open
fix: improve banner visibility on light terminal backgrounds#863HueCodes wants to merge 1 commit intobee-san:masterfrom
HueCodes wants to merge 1 commit intobee-san:masterfrom
Conversation
Fixes bee-san#778 The banner was hard to read on light terminal themes because it used bright green and yellow colors designed for dark backgrounds. Changes: - Add terminal-light crate to detect terminal background luminance - Add is_light_terminal() to detect light vs dark terminals - Add banner_colors() to select appropriate colors per theme - Light terminals now use DarkBlue/DarkOrange instead of Green/Yellow - Falls back to dark theme colors if detection fails (preserving existing behavior) - Add unit tests for color selection logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds automatic terminal background detection to improve banner visibility on light themes.
terminal-lightcrate to detect terminal luminanceFixes #778