perf: remove ToFullString call in Compare#1722
Open
TimothyMakkison wants to merge 1 commit intobelav:mainfrom
Open
perf: remove ToFullString call in Compare#1722TimothyMakkison wants to merge 1 commit intobelav:mainfrom
ToFullString call in Compare#1722TimothyMakkison wants to merge 1 commit intobelav:mainfrom
Conversation
TimothyMakkison
force-pushed
the
using_sorter
branch
from
1e6a103 to
cbf9389
Compare
TimothyMakkison
force-pushed
the
using_sorter
branch
from
cbf9389 to
8e39f60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is more aimed at formatting smaller files which usually only contain usings and a simple POCO. Has the added benefit of preventing any$O(n\log n)$
object allocations that may be prevalent in the odd files with loads of usings.
ToFullStringcalls inside the comparer and cache valuesToListcalls