perf: optimise IgnoreFile using ValueTask and Span.Replace#1740
Draft
TimothyMakkison wants to merge 2 commits intobelav:mainfrom
Draft
perf: optimise IgnoreFile using ValueTask and Span.Replace#1740TimothyMakkison wants to merge 2 commits intobelav:mainfrom
IgnoreFile using ValueTask and Span.Replace#1740TimothyMakkison wants to merge 2 commits intobelav:mainfrom
Conversation
TimothyMakkison
force-pushed
the
optimise_cli_ignore
branch
from
c5f0b65 to
1232ee6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValueTaskto avoid allocating aTaskin synchronous pathsstackallocSpan<char>to resize and reformat pathsFuncSaves around 5 MB, need to figure out how to benchmark this