updated dns to support regex + fixed loop + fixed assumptions#3
Open
eyJhb wants to merge 1 commit intobelyalov:masterfrom
Open
updated dns to support regex + fixed loop + fixed assumptions#3eyJhb wants to merge 1 commit intobelyalov:masterfrom
eyJhb wants to merge 1 commit intobelyalov:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially I couldn't get tinydns to run at all, which was fixed in the commit below.
As well as added support for using regex for domains, which could maybe be enabled/disabled (for usecases where it's not needed).
Besides this, some assumptions was made about the structure of the question packet, which was not always true, ie. when using dig it would send additional information, which this library did not handle well.
Now it parses the response one byte at a time,instead of reading at the end.
Things that should be fixed
.in domain