add pagination by LISBON11 · Pull Request #59 · bem/bem-forum

LISBON11 · 2017-07-25T01:47:12Z

No description provided.

skad0 · 2017-07-25T09:41:56Z

common.blocks/pager/pager.bemtree.js

-    var pagination = Object.assign({ current: true }, this.data.pagination);
+block('pager').content()(node => {
+    const { data } = node;
+    var pagination = Object.assign({ current: true }, data.pagination);


skad0 · 2017-07-25T09:42:02Z

common.blocks/pager/pager.bemtree.js

+    var pagination = Object.assign({ current: true }, data.pagination);
+    const pageCount = pagination.last ? pagination.last.match(/\&page=(\d+)/i)[1] :
+        parseInt(pagination.prev.match(/\&page=(\d+)/i)[1]) + 1;
+    var result = [];


skad0 · 2017-07-25T09:42:10Z

common.blocks/pager/pager.bemtree.js


-    return ['first', 'prev', 'current', 'next', 'last'].reduce((acc, type) => {
-        pagination[type] && acc.push({
+    var createItem = (type, index) => {


skad0 · 2017-07-25T09:42:20Z

common.blocks/pager/pager.bemtree.js

+        };
+    };
+
+    for (var i = 1; i <= pageCount; i++) {


skad0 · 2017-07-25T09:43:57Z

common.blocks/pager/pager.bemtree.js

+        result.push(createItem('number', i));
+    }
+
+    return ['first', 'prev'].reduce((acc, type, index) => {


к этому блоку не хватает комментария

skad0 · 2017-07-25T09:50:05Z

А еще это получается не добавление пагинации, а фикс/доработка

LISBON11 · 2017-07-25T12:19:36Z

common.blocks/pager/pager.bemtree.js

+block('pager').content()(node => {
+    const { data } = node;
+    const pagination = Object.assign({ current: true }, data.pagination);
+    const pageCount = pagination.last ? pagination.last.match(/\&page=(\d+)/i)[1] :


LISBON11 · 2017-07-25T12:20:05Z

common.blocks/pager/pager.bemhtml.js

+block('pager')
+.elem('item')
+.match(function() { return this.ctx.url !== true; })
+.replace()(function() {


arrow funcs

LISBON11 · 2017-07-25T12:20:54Z

common.blocks/pager/pager.bemtree.js

            elemMods: { type: type },
-            url: pagination[type]
-        });
+            url: pagination[type] || `?page=${index}`,


keep other params

LISBON11 · 2017-07-25T12:21:16Z

common.blocks/pager/pager.bemtree.js

+    }
+
+    // собираем последовательность из стрелок начала, цифер  и стрелок конца
+    return ['first', 'prev'].reduce((acc, type, index) => {


return [ [].reduce(), result, [].reduce() ];

volkov97 · 2017-08-02T15:09:42Z

common.blocks/sidebar/__sorting/sidebar__sorting.js

+            delete params.page;
+
+            Location.change({ params: params });
+            window.location.reload();


Ajax will not work with location.reload :(

мы хотим здесь ajax?

да, там уже ajax есть

tadatuta · 2017-08-04T15:47:20Z

common.blocks/pager/pager.bemhtml.js

-block('pager').elem('item').match(function() { return this.ctx.url !== true; }).replace()(function() {
+block('pager')
+.elem('item')
+.match(node => { return node.ctx.url !== true; })


- .match(node => { return node.ctx.url !== true; }) + .match(node => node.ctx.url !== true)

tadatuta · 2017-08-04T15:49:34Z

common.blocks/pager/pager.bemtree.js

+        result.push(createItem('number', i));
+    }
+
+    // собираем последовательность из стрелок начала, цифер  и стрелок конца


- цифер + цифр

but let's keep comments in English ;)

tadatuta · 2017-08-04T15:50:20Z

common.blocks/sidebar/__sorting/sidebar__sorting.js

                Location.getUri().queryParams,
-                { sort, direction },
-                { pagination: undefined }
+                { sort, direction }


only ES5 on client side

tadatuta · 2017-08-04T15:50:29Z

server/controllers/gh.js

+            querystring.parse(issuesData.pagination.last).page :
+            parseInt(querystring.parse(issuesData.pagination.prev).page) + 1;
+
+        var exceptPagUrl = querystring.parse(issuesData.pagination.last || issuesData.pagination.prev);


var -> const

LISBON11 · 2017-08-09T18:20:41Z

server/controllers/gh.js

+        querystring.parse(issuesPag.last).page :
+        parseInt(querystring.parse(issuesPag.prev).page) + 1;
+
+    let exceptPagUrl = querystring.parse(issuesPag.last || issuesPag.prev);


if there is ? at the beginning use .substr(1) here

LISBON11 · 2017-08-09T18:21:01Z

server/controllers/gh.js

+    let exceptPagUrl = querystring.parse(issuesPag.last || issuesPag.prev);
+    delete exceptPagUrl.page;
+
+    exceptPagUrl = Object.keys(exceptPagUrl).reduce((resStr, key) => {


use querystring.stringify() instead

LISBON11 · 2017-08-09T18:21:22Z

server/controllers/gh.js

-            labels: labelsData
+            labels: labelsData,
+            pageCount: paginationData.pageCount,
+            exceptPagUrl: paginationData.exceptPagUrl


replace *pag* with pagination

LISBON11 · 2017-08-09T18:23:06Z

server/controllers/gh.js

+                render(req, res, {
+                    view: 'page-post'
+                },
+                    Object.assign({


extra indent

tadatuta · 2017-10-01T18:06:03Z

server/controllers/gh.js

+function getPaginationData(issuesPag) {
+    const querystring = require('querystring'),
+        pageCount = issuesPag.last ?
+        querystring.parse(issuesPag.last).page :


indentation here and everywhere

skad0 requested changes Jul 25, 2017

View reviewed changes

LISBON11 force-pushed the pagination branch from 6edf67e to 46fc107 Compare July 25, 2017 10:51

LISBON11 commented Jul 25, 2017

View reviewed changes

LISBON11 force-pushed the pagination branch 4 times, most recently from d937b26 to 55254ce Compare August 2, 2017 12:17

volkov97 requested changes Aug 2, 2017

View reviewed changes

LISBON11 force-pushed the pagination branch from 3ccd156 to 451cdd0 Compare August 4, 2017 13:01

volkov97 approved these changes Aug 4, 2017

View reviewed changes

tadatuta reviewed Aug 4, 2017

View reviewed changes

LISBON11 added 4 commits August 8, 2017 08:40

fix pagination

fd0d6f9

save previous url params when changing page event happends

a7c9f08

fix page params

fa3df3b

add arrow fn and fix ajax

1916d22

LISBON11 force-pushed the pagination branch 3 times, most recently from 8a5022e to 437922a Compare August 8, 2017 08:55

some fixes

729dd84

LISBON11 force-pushed the pagination branch from 437922a to 729dd84 Compare August 8, 2017 12:27

LISBON11 commented Aug 9, 2017

View reviewed changes

LISBON11 and others added 2 commits September 30, 2017 15:03

pagination: fix state params passed form server

e2076b1

Merge branch 'master' into pagination

b329c59

tadatuta reviewed Oct 1, 2017

View reviewed changes

skad0 self-assigned this Oct 19, 2017

skad0 removed their assignment Jul 16, 2020

Conversation

LISBON11 commented Jul 25, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

skad0 commented Jul 25, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants