Cargo-criterion tool support#145
Cargo-criterion tool support#145brainstorm wants to merge 32 commits intobenchmark-action:masterfrom
Conversation
…erion-rs benchmark outputs
…report is WIP, need to investigate if it's already supported on the other supported tools
… side, namely multiple benchmark reports, not just single
… side, namely multiple benchmark reports, not just single
…m/github-action-benchmark into cargo-criterion-tool-extractor
… multiple newlines to improve readability (and break the tests as a result)
… payload size for easy expected/actual matching
…ning about it missing anyway
|
When |
Oh, sorry about that, can you point me in the code or show me some errors where you are having issues? IIRC it works for our multiple cargo criterion benchmark outputs, so I need a bit more details to diagnose this issue... |
I'm still getting the same issue here. |
|
If anyone else is blocked by this, Bencher supports Criterion: https://github.com/bencherdev/bencher#supported-benchmark-harnesses |
|
If anyone else is blocked by this, cargo-criterion supports outputing in |
|
up |
After struggling with
cargo benchintegration with criterion-rs and this action, I've decided to add support forcargo criterionwhich adds improvements in several areas vs the plain criterion-rs bench+plaintext extract approach.Here are some examples of the outputs generated by this PR:
https://umccr.github.io/htsget-rs/dev/bench/ <--- generated by this action
https://umccr.github.io/htsget-rs/dev/bench/native/criterion/reports/ <--- generated by cargo-criterion natively and pushed to
gh-pagesbranch as-is./cc @mmalenic