-
Notifications
You must be signed in to change notification settings - Fork 88
Write EIP 2935 Gas Comparison Guide #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@codingwithmanny @okjintao I am cleaning up the README tonight and preparing an X thread alongside my other guide. I will migrate the The system contract that is associated to EIP-2935 is not shown anywhere that I could see. I'll message the smart contract team too to double check on it. To showcase the gas savings though, one can do it with a mock system contract, which is what I did. |
|
Should be all good, but I gotta do a fresh clone of the repo and run it to ensure robustness. |
okjintao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we show how you can leverage these using viem?
|
|
||
| This quickstart covers [EIP-2935, _an EIP focused on historical block hashes from state_,](https://eips.ethereum.org/EIPS/eip-2935) and how it enables gas optimizations for applications building on Berachain. It is part of the [Bectra upgrade](https://x.com/berachain/status/1930326162577776655), which brings Ethereum’s Pectra-era EIPs to Berachain. | ||
|
|
||
| A more detailed version of this guide, with context on EIP-2935, can be found within our [docs](https://docs.berachain.com/developers/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should have the real link. this is a bit weird to me since the docs should just be explaining vs. guide so just more for more information on eip 2935 maybe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding was it was the opposite:
- docs would have the detailed explanation, including EIP2935 context etc.
- guide was a
quickstartwith the code and everything.
This was based on what Manny had requested from me for EIP7702, but maybe I misinterpreted, or it really should be the other way around.
As for the link, I can't update it until the docs PR is merged and vice versa. Then I'd have the proper docs URL to put in. I guess I can put in what it should be ahead of time.
|
@okjintao Thank you for the review! I made the changes you've outlined for the most part. Only need to sync up on how the
As per this question, I think the scope was just to showcase the gas savings. If you think |
okjintao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm will let @codingwithmanny merge, wrt the guide vs. docs i meant more just like the docs should reference this and the guides are complimentary vs. the docs being a superset of the guides.
Signed-off-by: Ichiraku Bera <209535819+IchiBera@users.noreply.github.com>
Guide Contribution PR
Description
This quickstart covers EIP-2935, an EIP focused on historical block hashes from state, and how it enables gas optimizations for applications building on Berachain. It is part of the Bectra upgrade, which brings Ethereum’s Pectra-era EIPs to Berachain.
This guide specifically shows obtaining a historic blockhash using the power of EIP-2935 and its system contracts, all on Bepolia. This can be done on Berachain as well.
Type of Change
Guide Details
Checklist
Additional Notes