add support for ca65 error messages#244
Merged
WillLillis merged 3 commits intobergercookie:masterfrom Apr 22, 2025
Merged
Conversation
WillLillis
requested changes
Apr 22, 2025
Collaborator
WillLillis
left a comment
WillLillis
left a comment
There was a problem hiding this comment.
Functionally looks great! I left a few minor style suggestions. Thanks a ton for the PR! :)
Co-authored-by: Will Lillis <will.lillis24@gmail.com>
Co-authored-by: Will Lillis <will.lillis24@gmail.com>
Contributor
Author
|
thx for the fast response 😄 i applied your suggestions. |
WillLillis
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added support for the error format of the ca65 assembler.
i also have seen the comment on line 678, so i tried to avoid making more Regex shenanigan 🙈