fix(lsp): send error response to request when no data is available#257
Merged
WillLillis merged 5 commits intobergercookie:masterfrom Sep 7, 2025
Merged
fix(lsp): send error response to request when no data is available#257WillLillis merged 5 commits intobergercookie:masterfrom
WillLillis merged 5 commits intobergercookie:masterfrom
Conversation
Sending a response with both `error` and `result` set to `None` does not conform to the LSP spec, and results in an error being displayed by Neovim's client.
|
Any chance you could cut a release including these changes? |
Collaborator
Author
Sure thing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sending a response with both
errorandresultset toNonedoes notconform to the LSP spec, and results in an error being displayed by
Neovim's client.
With this change, we no longer have to special-case Helix's client.
Also, this PR also makes use of the new nested if let chains.