log: custom logging using loglevel & enum LogLevel#213
Open
canewsin wants to merge 1 commit intobernaferrari:mainfrom
Open
log: custom logging using loglevel & enum LogLevel#213canewsin wants to merge 1 commit intobernaferrari:mainfrom
loglevel & enum LogLevel#213canewsin wants to merge 1 commit intobernaferrari:mainfrom
Conversation
Owner
|
Does this help you in any way or is it just code cosmetic? |
Contributor
Author
|
increases code gen speed for large components and frames. |
Owner
|
Via log level? Because there shouldn't be any difference right? |
Contributor
Author
|
yup, codebase has many console.log/warn statements, we may forgot to remove and it's not trival to comment and uncomment all the time while development. with this |
Owner
|
I like it, sorry if it is slow, I should probably fix that. If we do something like: const originalLog = console.log;
console.log = function(...args) {
originalLog.apply(console, ["Node log:", ...args]);
};then we don't need to override it everywhere/import everywhere and can be the best of both worlds. I'll try this solution. |
Contributor
Author
Contributor
Author
|
@bernaferrari pushed with suggested changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.