Feat/reconciliation loop #1951
Open
Feat/reconciliation loop #1951
+34,462
−24,458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despire
requested review from
JKBGIT1,
bernardhalas,
m-brando and
samuelstolicny
and removed request for
JKBGIT1 and
m-brando
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to resolve the following issues:
Initial work on #150
Closes #1627
Closes #1617
Closes #1316
This PR introduces a refactor that get rids of the Builder service and adds NATS as a worker queue to distribute the messages between the workers (terraformer, ansibler, kube-eleven, kuber).
Further, this PR introduces the initial work on the reconciliation loop which works as follows:
Once a change is detected the diff is worked out and is applied, if it fails claudie rolls back to the original state will proceed to again diff with the desired state. This will be an endless reconciliation loop that will always try to build the desired state even on failures.
Contrary to how claudie in
masterworks, which after a failure is encountered logs the error and nothing is done until the manifest is again updated. Usually on errors it was enough to retry, thus some users were manually editing nodepool labels to trigger the reconciliation. Which is now completely obsolete as claudie will work it out on itself, it will be enough to update the manifest for the desired state.