Fix control button enabled despite having disableColor#244
Open
JaviMetalCBA wants to merge 1 commit intobest-flutter:masterfrom
Open
Fix control button enabled despite having disableColor#244JaviMetalCBA wants to merge 1 commit intobest-flutter:masterfrom
JaviMetalCBA wants to merge 1 commit intobest-flutter:masterfrom
Conversation
Fixed control buttons making jump-loops despite showing disableColor. My implementation conditions the onTap response to the button color or loop being enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the jump-loops caused by control buttons showing disableColor, by conditioning the onTap animation to a true loop status or the existence of previous or next index.