refactor(Télédéclaration): supprime un serializer plus utilisé #1TD1Site

api/serializers/__init__.py

@@ -46,10 +46,9 @@
 from .password import PasswordSerializer  # noqa: F401
 from .managerinvitation import ManagerInvitationSerializer  # noqa: F401
 from .teledeclaration import (  # noqa: F401
-    ShortTeledeclarationSerializer,
     CampaignDatesSerializer,
     CampaignDatesFullSerializer,
-)  # noqa: F401
+)
 from .purchase import (  # noqa: F401
     PurchaseSerializer,
     PurchaseSummarySerializer,

api/serializers/diagnostic.py

@@ -5,7 +5,6 @@
 
 from data.models import Diagnostic
 
-from .teledeclaration import ShortTeledeclarationSerializer
 from .utils import appro_to_percentages
 
 logger = logging.getLogger(__name__)
@@ -153,8 +152,6 @@ def return_value(serializer, data, field_name):
 
 
 class FullDiagnosticSerializer(DiagnosticSerializer):
-    teledeclaration = ShortTeledeclarationSerializer(source="latest_submitted_teledeclaration")
-
     class Meta:
         model = Diagnostic
         fields = (

api/serializers/teledeclaration.py

@@ -1,19 +1,5 @@
 from rest_framework import serializers
 
-from data.models import Teledeclaration
-
-
-class ShortTeledeclarationSerializer(serializers.ModelSerializer):
-    class Meta:
-        model = Teledeclaration
-        fields = (
-            "id",
-            "creation_date",
-            "modification_date",
-            "status",
-        )
-        read_only_fields = fields
-
 
 class CampaignDatesSerializer(serializers.Serializer):
     year = serializers.IntegerField()

data/models/diagnostic.py

@@ -1622,13 +1622,6 @@ def canteen_snapshot_sector_list_display(self):
                     return ", ".join([x["name"] for x in (self.canteen_snapshot.get("sectors") or [])])
         return None
 
-    @property
-    def latest_submitted_teledeclaration(self):
-        submitted_teledeclarations = self.teledeclaration_set.submitted()
-        if submitted_teledeclarations.count() == 0:
-            return None
-        return submitted_teledeclarations.order_by("-creation_date").first()
-
     @property
     def appro_badge(self) -> bool | None:
         total = self.valeur_totale